linux-ext4 - Re: [PATCH 09/24] e2fsck: clear i_block if there are too many bad block mappings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140722185933.GM25291@thunk.org>
Date:	Tue, 22 Jul 2014 14:59:33 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 09/24] e2fsck: clear i_block if there are too many bad
 block mappings

On Fri, Jul 18, 2014 at 03:53:21PM -0700, Darrick J. Wong wrote:
> If there are too many bad block mappings in a file and the user says
> to zap it, erase i_block before clearing the inode.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>

Why is this necessary?  E2fsck will clear i_links_count and set dtime,
so the contents of i_block shouldn't matter, yes?

						- Ted

> 
> diff --git a/e2fsck/pass1.c b/e2fsck/pass1.c
> index b696d02..18980f1 100644
> --- a/e2fsck/pass1.c
> +++ b/e2fsck/pass1.c
> @@ -2329,6 +2329,7 @@ static void check_blocks(e2fsck_t ctx, struct problem_context *pctx,
>  	}
>  
>  	if (pb.clear) {
> +		memset(inode->i_block, 0, sizeof(inode->i_block));
>  		e2fsck_clear_inode(ctx, ino, inode, E2F_FLAG_RESTART,
>  				   "check_blocks");
>  		return;
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html