linux-ext4 - Re: [PATCH 09/24] e2fsck: clear i_block if there are too many bad block mappings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140722224827.GT25291@thunk.org>
Date:	Tue, 22 Jul 2014 18:48:27 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	f@...ch.djwong.org, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 09/24] e2fsck: clear i_block if there are too many bad
 block mappings

On Tue, Jul 22, 2014 at 03:14:26PM -0700, Darrick J. Wong wrote:
> On Tue, Jul 22, 2014 at 02:59:33PM -0400, Theodore Ts'o wrote:
> > On Fri, Jul 18, 2014 at 03:53:21PM -0700, Darrick J. Wong wrote:
> > > If there are too many bad block mappings in a file and the user says
> > > to zap it, erase i_block before clearing the inode.
> > > 
> > > Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>
> > 
> > Why is this necessary?  E2fsck will clear i_links_count and set dtime,
> > so the contents of i_block shouldn't matter, yes?
> 
> Hmm... oh, I think I remember where this patch came from.  When I wrote the
> patch "e2fsck: fix inode coherency issue when iterating an inode's blocks", I
> looked down a few lines to see what pb.clear == 1 did.  I figured that if the
> block mappings were really bad (i.e. there are more than 12 bad mappings), why
> not just wipe i_block entirely?
> 
> I didn't have a specific failure case in mind when I wrote this patch.

Ok, then I'll drop this.  In general I try to avoid unnecessary
zero'ing when possible.  It might be useful in doing a post morten
after the user runs e2fsck -y, and so long as inode is skipped, I'd
rather not zap more of the inode structure than is strictly necessary.

Cheers,

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html