linux-ext4 - Re: [PATCH 15/24] misc: fix problems with strncat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140725112207.GF1865@thunk.org>
Date:	Fri, 25 Jul 2014 07:22:07 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 15/24] misc: fix problems with strncat

On Fri, Jul 18, 2014 at 03:54:07PM -0700, Darrick J. Wong wrote:
> The third argument to strncat is the maximum number of characters to
> copy out of the second argument; it is not the maximum length of the
> first argument.
> 
> Therefore, code in a check just in case we ever find a /sys/block/X
> path long enough to hit the end of the buffer.  FWIW the longest path
> I could find on my machine was 133 bytes.
> 
> Fixes-Coverity-Bug: 1252003
> Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>

Thanks, applied.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html