linux-ext4 - Re: Online resize issue with 3.13.5 & 3.15.6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53D24307.6050903@fnarfbargle.com>
Date:	Fri, 25 Jul 2014 19:44:07 +0800
From:	Brad Campbell <lists2009@...rfbargle.com>
To:	Azat Khuzhin <a3at.mail@...il.com>
CC:	linux-ext4@...r.kernel.org
Subject: Re: Online resize issue with 3.13.5 & 3.15.6

On 25/07/14 16:13, Azat Khuzhin wrote:
> On Mon, Jul 21, 2014 at 09:03:22AM +0800, Brad Campbell wrote:
>> On 20/07/14 19:26, Brad Campbell wrote:
>> Added 131072 extra group(s), blks_needed 4374122900, data_blocks 79184732,
>> last_start 5781865048
>
> blocks_per_group=32768 (u32)
> extra_groups=131072 (u32)
> b*e=4294967296 # overflow
>
> Could you try attached patched? (I will add appropriate message letter)
> It is totally untested and shouldn't break anything, *but* I strongly
> recommend you to have a backup before running it.
> You could also wait until somebody else review it.
>
> diff --git a/resize/resize2fs.c b/resize/resize2fs.c
> index a8af969..98ce10a 100644
> --- a/resize/resize2fs.c
> +++ b/resize/resize2fs.c
> @@ -2479,7 +2479,8 @@ blk64_t calculate_minimum_resize_size(ext2_filsys fs, int flags)
>                  extra_grps = ext2fs_div64_ceil(remainder,
>                                                 EXT2_BLOCKS_PER_GROUP(fs->super));
>
> -               data_blocks += extra_grps * EXT2_BLOCKS_PER_GROUP(fs->super);
> +               data_blocks += (unsigned long long)extra_grps *
> +                       EXT2_BLOCKS_PER_GROUP(fs->super);
>
>                  /* ok we have to account for the last group */
>                  overhead = calc_group_overhead(fs, groups-1, old_desc_blocks);
>
>

G'day Azat,

Appreciate you taking a look at this and I see where you are going with it.

While I have a backup of _all_ critical data on that array, I don't have 
20TB of spare space to back up the remainder so if you don't mind I'd 
like to wait for a review prior to letting it loose on the array.

Regards,
Brad
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html