linux-ext4 - Re: [PATCH] ext4: Add support for FIDTRIM, a best-effort ioctl for deep discard trim

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <EFCA683A-25F1-4A58-9500-42E2FD044656@dilger.ca>
Date:	Thu, 24 Jul 2014 21:46:38 -0600
From:	Andreas Dilger <adilger@...ger.ca>
To:	JP Abgrall <jpa@...gle.com>
Cc:	Dave Chinner <david@...morbit.com>, linux-ext4@...r.kernel.org,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	Geremy Condra <gcondra@...gle.com>
Subject: Re: [PATCH] ext4: Add support for FIDTRIM, a best-effort ioctl for deep discard trim


On Jul 24, 2014, at 7:50 PM, JP Abgrall <jpa@...gle.com> wrote:
> On Thu, Jul 24, 2014 at 5:08 AM, Dave Chinner <david@...morbit.com> wrote:
>> 
>> On Wed, Jul 23, 2014 at 04:47:18PM -0700, JP Abgrall wrote:
>>> +#define FIDTRIM      _IOWR('X', 122, struct fstrim_range)    /* Deep discard trim */
>> 
>> The 'X' ioctl namespace is actually XFS's ioctl namespace. FIDTRIM
>> should be in the 'f' namespace
> 
> Ok.
> How should the next sequence number be handled?
> Go with ('f', 122,...) after FITRIM, or go with ('f', 12,...) after
> FS_IOC_FIEMAP ('f' namepsace)?

Please leave the low 'f' values for ext2/3/4 (where FS_IOC_[GS]ETFLAGS,
FS_IOC_[GS]ETFLAGS, and FS_IOC_FIEMAPand came from, and use high 'f'
numbers, maybe starting at 128 (?) for generic ioctl values.

Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)