linux-ext4 - Re: [PATCH 08/18] e2fsck: fix the various checksum error messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140726210953.GQ6725@thunk.org>
Date:	Sat, 26 Jul 2014 17:09:53 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 08/18] e2fsck: fix the various checksum error messages

On Fri, Jul 25, 2014 at 05:34:28PM -0700, Darrick J. Wong wrote:
> Make the "EA block passes checks but fails checksum" message less
> strange, and make the other checksum error messages actually print a
> period at the end of the sentence.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>

Applied (with some slight adjustments since I haven't pulled in the
previous patch pending discussion).  I note that there was no need to
adjust any of the expected messages in the e2fsprogs regression tests.

This indicates that we don't have enough (well, any) regression tests
covering the metadata checksum feature.  :-(

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html