linux-ext4 - Re: [PATCH] resize2fs: fix 32bit overflow during minimal size calculation for 64bit fs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140726215341.GU6725@thunk.org>
Date:	Sat, 26 Jul 2014 17:53:41 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Azat Khuzhin <a3at.mail@...il.com>
Cc:	linux-ext4@...r.kernel.org, lists2009@...rfbargle.com
Subject: Re: [PATCH] resize2fs: fix 32bit overflow during minimal size
 calculation for 64bit fs.

On Sat, Jul 26, 2014 at 11:19:27AM +0400, Azat Khuzhin wrote:
> calculate_minimum_resize_size() multiplying two 32bit numbers, however the
> result must be 64bit, but it will be truncated to 32bit, and because of this
> data_blocks will be zero, and it will never leave loop...

There is a much more general patch which solves a number of other
instances where this bug exists which I've already committed into my
tree:

https://git.kernel.org/cgit/fs/ext2/e2fsprogs.git/commit/?h=maint&id=1e33a8b408123a4e02a6b9135807f6fd61f3e235

Cheers,

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html