linux-ext4 - Re: [PATCH 17/18] e2fsck: make insert_dirent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140727234856.GD6725@thunk.org>
Date:	Sun, 27 Jul 2014 19:48:56 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 17/18] e2fsck: make insert_dirent_tail more robust

On Fri, Jul 25, 2014 at 05:35:25PM -0700, Darrick J. Wong wrote:
> Fix the routine that adds dirent checksum structures to the directory
> block to handle oddball situations a bit more robustly.
> 
> First, when we're walking the entry array, we might encounter an
> entry that ends exactly one byte before where the checksum entry needs
> to start, i.e. there's space for the tail entry, but it needs to be
> reinitialized.  When that happens, we should proceed until d points to
> that space so that the tail entry can be initialized.
> 
> Second, it's possible that we've been fed a directory block where the
> entries end just short of the end of the block.  In this case, we need
> to adjust the size of the last entry to point exactly to where the
> dirent tail starts.  The current code requires that entries end
> exactly on the block boundary, but this is not always the case with
> damaged filesystems.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>

Applied, thanks.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html