linux-ext4 - Re: [PATCH] ext4: save goal group and offset in struct ext4_allocation_context.ac_g

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140801124037.GB15110@thunk.org>
Date:	Fri, 1 Aug 2014 08:40:37 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Xiaoguang Wang <wangxg.fnst@...fujitsu.com>
Cc:	linux-ext4@...r.kernel.org, adilger@...ger.ca, lczerner@...hat.com
Subject: Re: [PATCH] ext4: save goal group and offset in struct
 ext4_allocation_context.ac_g_ex

On Fri, Aug 01, 2014 at 09:13:49AM +0800, Xiaoguang Wang wrote:
> > I'm not sure why, and right now I don't have time to investigate.  If
> > someone who has time and experience wading into fs/ext4/mballoc.c, it
> > would be great if someone could take a closer look.
> 
> I'll investigate it and have full tests, thanks!

Thanks!  

The patch *looked* correct, and it was pretty obvious, so I don't
entirely blame you for not running tests --- but it's why I tend to
run smoke tests regularly when merging in patches, and I do encourage
folks to run the smoke test for any patch, no matter how simple.  Yes,
it takes 30 minutes, but it's worth it.

I suspect there may be some underlying bug which your patch unmasked,
so it would be good for us to understand why it caused the failure.

      	       	    	      		     - Ted

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html