linux-ext4 - Re: [PATCH 25/37] libext2fs: when appending to a file, don't split an index block in equal halves

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140802234348.GC29146@thunk.org>
Date:	Sat, 2 Aug 2014 19:43:48 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 25/37] libext2fs: when appending to a file, don't split
 an index block in equal halves

On Thu, May 01, 2014 at 04:15:05PM -0700, Darrick J. Wong wrote:
> When we're appending an extent to the end of a file and the index
> block is full, don't split the index block into two half-full index
> blocks because this leaves us with under utilized index blocks, at
> least in the fallocate case.  Instead, copy the last extent from the
> full block into the new block.  This isn't perfect utilization, but
> there's a lot of work involved in teaching extent.c to be able to goto
> a nonexistent node in a newly allocated (and empty) extent block.
> 
> This patch does not fix the general problem of keeping the extent tree
> balanced.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>

Applied, thanks.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html