[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20140802013206.GC27252@thunk.org>
Date: Fri, 1 Aug 2014 21:32:06 -0400
From: Theodore Ts'o <tytso@....edu>
To: Andreas Dilger <adilger@...ger.ca>
Cc: Ext4 Developers List <linux-ext4@...r.kernel.org>,
Azat Khuzhin <a3at.mail@...il.com>,
Eric Sandeen <sandeen@...hat.com>
Subject: Re: [PATCH] tune2fs: fix uninitialized variable in
remove_journal_device
On Fri, Aug 01, 2014 at 08:38:30AM +0200, Andreas Dilger wrote:
> > /* Write back the journal superblock */
> > - if ((retval = io_channel_write_blk64(jfs->io, start,
> > - -SUPERBLOCK_SIZE, buf))) {
> > + if ((retval = io_channel_write_blk64(jfs->io,
> > + ext2fs_journal_sb_start(fs->blocksize),
> > + -SUPERBLOCK_SIZE, buf))) {
>
> Better to also remove assignment in conditional check.
Good point, done.
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists