linux-ext4 - Re: [PATCH 12/19] e2fsck: always ask to fix an inode that fails checksum verification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140803025539.GL24826@thunk.org>
Date:	Sat, 2 Aug 2014 22:55:39 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 12/19] e2fsck: always ask to fix an inode that fails
 checksum verification

On Fri, Aug 01, 2014 at 11:13:00AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@...cle.com>
> 
> If an inode fails checksum verification during pass 1 and the user
> doesn't fix or clear the inode as part of the regular inode checks,
> ensure that e2fsck remembers to ask the user if he simply wants to
> correct the checksum.
> 
> We weren't capturing all the ways out of an interation of the inode
> scanning loop, which means that not all errors were caught.  Also,
> we might as well clear the 'failed csum' flag if we write the inode
> directly from the inode scanning loop.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>

Applied, thanks.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html