linux-ext4 - Re: [PATCH v2] ext4: check inline directory before converting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <loom.20140805T141533-363@post.gmane.org>
Date:	Tue, 5 Aug 2014 12:20:12 +0000 (UTC)
From:	Patrick Palka <patrick@...cs.ath.cx>
To:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH v2] ext4: check inline directory before converting

Hi,

Darrick J. Wong <darrick.wong <at> oracle.com> writes:

> +int ext4_check_all_de(struct inode *dir, struct buffer_head *bh, void 
*buf,
> +		      int buf_size)
> +{
> +	struct ext4_dir_entry_2 *de;
> +	int nlen, rlen;

Is nlen actually used in this function?

> +	unsigned int offset = 0;
> +	char *top;
> +
> +	de = (struct ext4_dir_entry_2 *)buf;
> +	top = buf + buf_size;
> +	while ((char *) de < top) {
> +		if (ext4_check_dir_entry(dir, NULL, de, bh,
> +					 buf, buf_size, offset))
> +			return -EIO;
> +		nlen = EXT4_DIR_REC_LEN(de->name_len);

It is set here, but its value is never used.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html