linux-ext4 - Re: [PATCH] ext3: Count internal journal as bsddf overhead in ext3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140819212013.GA3271@quack.suse.cz>
Date:	Tue, 19 Aug 2014 23:20:13 +0200
From:	Jan Kara <jack@...e.cz>
To:	Chin-Tsung Cheng <chintzung@...il.com>
Cc:	jack@...e.cz, akpm@...ux-foundation.org, adilger.kernel@...ger.ca,
	linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ext3: Count internal journal as bsddf overhead in
 ext3_statfs

On Fri 15-08-14 15:49:31, Chin-Tsung Cheng wrote:
> The journal blocks of external journal device should not
> be counted as overhead.
  Thanks. I've added the patch to my tree.

								Honza

> 
> Signed-off-by: Chin-Tsung Cheng <chintzung@...il.com>
> ---
>  fs/ext3/super.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ext3/super.c b/fs/ext3/super.c
> index 08cdfe5..622e882 100644
> --- a/fs/ext3/super.c
> +++ b/fs/ext3/super.c
> @@ -2828,8 +2828,9 @@ static int ext3_statfs (struct dentry * dentry, struct kstatfs * buf)
>  		 */
>  		overhead += ngroups * (2 + sbi->s_itb_per_group);
>  
> -		/* Add the journal blocks as well */
> -                overhead += sbi->s_journal->j_maxlen;
> +		/* Add the internal journal blocks as well */
> +		if (sbi->s_journal && !sbi->journal_bdev)
> +			overhead += sbi->s_journal->j_maxlen;
>  
>  		sbi->s_overhead_last = overhead;
>  		smp_wmb();
> -- 
> 1.9.3
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html