linux-ext4 - Re: [PATCHv2 1/3] fs/buffer.c: allocate buffer cache with user specific flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53F53F72.9050305@lge.com>
Date:	Thu, 21 Aug 2014 09:38:10 +0900
From:	Gioh Kim <gioh.kim@....com>
To:	Jan Kara <jack@...e.cz>
CC:	Alexander Viro <viro@...iv.linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Peter Zijlstra <peterz@...radead.org>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	Theodore Ts'o <tytso@....edu>,
	Andreas Dilger <adilger.kernel@...ger.ca>,
	linux-ext4@...r.kernel.org, Minchan Kim <minchan@...nel.org>,
	Joonsoo Kim <js1304@...il.com>,
	이건호 <gunho.lee@....com>
Subject: Re: [PATCHv2 1/3] fs/buffer.c: allocate buffer cache with user specific
 flag



2014-08-21 오전 7:02, Jan Kara 쓴 글:
> On Wed 20-08-14 11:38:10, Gioh Kim wrote:
>>
>>>>>> @@ -1381,12 +1383,7 @@ EXPORT_SYMBOL(__find_get_block);
>>>>>>   struct buffer_head *
>>>>>>   __getblk(struct block_device *bdev, sector_t block, unsigned size)
>>>>>>   {
>>>>>> -       struct buffer_head *bh = __find_get_block(bdev, block, size);
>>>>>> -
>>>>>> -       might_sleep();
>>>>>> -       if (bh == NULL)
>>>>>> -               bh = __getblk_slow(bdev, block, size);
>>>>>> -       return bh;
>>>>>> +       return __getblk_gfp(bdev, block, size, __GFP_MOVABLE);
>>>>>>   }
>>>>>>   EXPORT_SYMBOL(__getblk);
>>>>>    Why did you remove the __find_get_block() call? That looks like a bug.
>>>    I'm not sure if you didn't miss this comment....
>>
>> I'm sorry I missed it.
>> I think calling __find_get_block() in __getblk_gfp() can replace it.
>> I'm not sure about it.
>>
>> If anybody disagree with it, I'll change it as the original code.
>    OK, I see. Thanks for explanation. I agree we can remove
> __find_get_block() from __getblk() but please make this change a separate
> patch and also please put the might_sleep() check __getblk_gfp().
>
> 								Honza
>

I got it.
I'm going to report v3 patch that reverts __getblk() and adds sb_bread_unmovable(),
if Andrew give me a feedback about the other codes.
I can wait ;-)

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html