linux-ext4 - Potential bug in fs/ext4/inline.c?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140821220126.GA3597@thunk.org>
Date:	Thu, 21 Aug 2014 18:01:26 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	gnehzuil.liu@...il.com
Cc:	linux-ext4@...r.kernel.org
Subject: Potential bug in fs/ext4/inline.c?

In ext4_find_inline_entry(), there is the following:

	if (ext4_get_inline_size(dir) == EXT4_MIN_INLINE_DATA_SIZE)
		goto out;

Am I missing something, or shouldn't this be:

	if (ext4_get_inline_size(dir) <= EXT4_MIN_INLINE_DATA_SIZE)
		goto out;

?

Thanks,

						- Ted

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html