linux-ext4 - Re: [PATCH 05/27] e2fsck: on BE, re-swap everything after a damaged dirent so salvage works correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140825020312.GL6236@thunk.org>
Date:	Sun, 24 Aug 2014 22:03:12 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 05/27] e2fsck: on BE, re-swap everything after a damaged
 dirent so salvage works correctly

On Sat, Aug 16, 2014 at 04:46:23PM -0700, Darrick J. Wong wrote:
> On big-endian systems, if the dirent swap routine finds a rec_len that
> it doesn't like, it continues processing the block as if rec_len == 8.
> This means that the name field gets byte swapped, which means that
> salvage will not detect the correct name length (unless the name has a
> length that's an exact multiple of four bytes), and it'll discard the
> entry (unnecessarily) and the rest of the dirent block.  Therefore,
> swap the rest of the block back to disk order, run salvage, and
> re-swap anything after the salvaged dirent.
> 
> The test case for this is f_inlinedata_repair if you run it on a BE
> system.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>

Thanks, applied.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html