linux-ext4 - Re: [PATCH 11/27] e2fsck/debugfs: fix descriptor block size handling errors with journal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140828011546.GA21925@thunk.org>
Date:	Wed, 27 Aug 2014 21:15:46 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	linux-ext4@...r.kernel.org, TR Reardon <thomas_reardon@...mail.com>
Subject: Re: [PATCH 11/27] e2fsck/debugfs: fix descriptor block size handling
 errors with journal_csum

On Sat, Aug 16, 2014 at 04:47:01PM -0700, Darrick J. Wong wrote:
> diff --git a/misc/dumpe2fs.c b/misc/dumpe2fs.c
> index 7cbb99b..9924285 100644
> --- a/misc/dumpe2fs.c
> +++ b/misc/dumpe2fs.c
> @@ -415,8 +415,10 @@ static void print_inline_journal_information(ext2_filsys fs)
>  	if (jsb->s_feature_compat &
>  	    ext2fs_cpu_to_be32(JFS_FEATURE_COMPAT_CHECKSUM))
>  		printf("%s", _("Journal checksum type:    crc32\n"));
> -	if (jsb->s_feature_incompat &
> -	    ext2fs_cpu_to_be32(JFS_FEATURE_INCOMPAT_CSUM_V2))
> +	if ((jsb->s_feature_incompat &
> +	     ext2fs_cpu_to_be32(JFS_FEATURE_INCOMPAT_CSUM_V2)) ||
> +	    (jsb->s_feature_incompat &
> +	     ext2fs_cpu_to_be32(JFS_FEATURE_INCOMPAT_CSUM_V2)))

I assume this should really be: 

+	if ((jsb->s_feature_incompat &
+	     ext2fs_cpu_to_be32(JFS_FEATURE_INCOMPAT_CSUM_V2)) ||
+	    (jsb->s_feature_incompat &
+	     ext2fs_cpu_to_be32(JFS_FEATURE_INCOMPAT_CSUM_V3)))
                                                         ^^^^

amd similarly below in the next if statement?

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html