linux-ext4 - Re: [PATCH] ext4: use mkfs.ext4 -F instead of piping in yes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140907192110.GC1066@thunk.org>
Date:	Sun, 7 Sep 2014 15:21:10 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	fstests@...r.kernel.org,
	Ext4 Developers List <linux-ext4@...r.kernel.org>,
	Xiaoguang Wang <wangxg.fnst@...fujitsu.com>,
	Eryu Guan <eguan@...hat.com>
Subject: Re: [PATCH] ext4: use mkfs.ext4 -F instead of piping in yes

On Sun, Sep 07, 2014 at 08:49:27AM -0700, Christoph Hellwig wrote:
> On Sun, Sep 07, 2014 at 08:29:02AM -0400, Theodore Ts'o wrote:
> > Using "yes | mkfs.ext4 ..." results in the error message results in
> > the test failing, at least for some versions of e2fsprogs:
> > 
> >     +yes: standard output: Broken pipe
> >     +yes: write error
> > 
> > It better to use the -F option, which will eliminate the questions.
> 
> Looks good, but maybe we should have a $MKFS_EXT4_PROG variable similar
> to $MKFS_XFS_PROG so that we can set this in one place?

Agreed, I'll send a separate patch to fix that.   One amusing thing:

% git grep mkfs.ext4
common/rc:_scratch_mkfs_ext4()
common/rc:      _scratch_mkfs_ext4 $*
common/rc:# this test requires the bigalloc feature to be available in mkfs.ext4
common/rc:      _scratch_mkfs_ext4 -O bigalloc >/dev/null 2>&1 \
common/rc:         || _notrun "mkfs.ext4 doesn't have bigalloc feature"
common/rc:      _scratch_mkfs_ext4 -O bigalloc >/dev/null 2>&1
tests/btrfs/012:MKFS_EXT4_PROG="`set_prog_path mkfs.ext4`"
tests/btrfs/012:_require_command $MKFS_EXT4_PROG mkfs.ext4
tests/ext4/003:mkfs.ext4 -F -O bigalloc -C 65536  -g 256 $SCRATCH_DEV 512m \
tests/ext4/306:mkfs.ext4 -F -O ^extents,^64bit $SCRATCH_DEV 512m >> $seqres.full 2>&1

(note the btrfs test is the one place using and defining MKFS_EXT4_PROG :-)

      	  	     	    	      	       - Ted

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html