linux-ext4 - Re: tune2fs -O ^metadata_csum not checking bitmap failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140910204840.GH10351@birch.djwong.org>
Date:	Wed, 10 Sep 2014 13:48:40 -0700
From:	"Darrick J. Wong" <darrick.wong@...cle.com>
To:	TR Reardon <thomas_reardon@...mail.com>
Cc:	"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>
Subject: Re: tune2fs -O ^metadata_csum not checking bitmap failures

On Wed, Sep 10, 2014 at 04:30:41PM -0400, TR Reardon wrote:
> When running tune2fs -O ^metadata_csum, disable_uninit_bg() is called to
> reset the gdt.  However, return value is not checked, which allows a failure
> (say, a block bitmap failure somewhere, among other errors) to continue
> through to rewrite_metadata_checksums()
> 
> This seems wrong; should not the rewrite occur only if
> disable/enable_uninit_bg() succeeds?

The rewrite will fail if either of the error cases in disable_uninit_bg() fail,
since rewrite_metadata_checksums() also tries to load the bitmap and scan the
inodes.

However, I wouldn't want to guarantee that in perpetuity, so let's check the
error codes anyway.

--D

> 
> +Reardon 		 	   		  --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html