linux-ext4 - Re: dumpe2fs: only print 'unused inodes' once

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140910214746.GJ10351@birch.djwong.org>
Date:	Wed, 10 Sep 2014 14:47:46 -0700
From:	"Darrick J. Wong" <darrick.wong@...cle.com>
To:	"Theodore Ts'o" <tytso@....edu>
Cc:	TR Reardon <thomas_reardon@...mail.com>,
	"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>
Subject: Re: dumpe2fs: only print 'unused inodes' once

On Wed, Sep 10, 2014 at 05:38:43PM -0400, Theodore Ts'o wrote:
> On Tue, Sep 09, 2014 at 12:47:46PM -0700, Darrick J. Wong wrote:
> > On Tue, Sep 09, 2014 at 03:32:56PM -0400, TR Reardon wrote:
> > > just a minor nit...and I don't think fixing this harms any existing tests.
> > 
> > Running 'make check' will tell you.
> > 
> > This also needs a Signed-off-by.
> 
> It also might make more sense to move the checksum to after the inode
> table, i.e., instead of:
> 
> Group 0: (Blocks 0-32767) [ITABLE_ZEROED]
>   Checksum 0xe0c6
>   Primary superblock at 0, Group descriptors at 1-1
>   Reserved GDT blocks at 2-512
>   Block bitmap at 513 (+513), Inode bitmap at 529 (+529)
>   Inode table at 545-1056 (+545)
>   24025 free blocks, 8181 free inodes, 2 directories, 8181 unused inodes
>   Free blocks: 8743-32767
>   Free inodes: 12-8192
> 
> how about:
> 
> Group 0: (Blocks 0-32767) [ITABLE_ZEROED]
>   Primary superblock at 0, Group descriptors at 1-1
>   Reserved GDT blocks at 2-512
>   Block bitmap at 513 (+513), Inode bitmap at 529 (+529)
>   Inode table at 545-1056 (+545), Checksum 0xe0c6

But... 0xE0C6 is the group descriptor checksum.  Since we report the bitmap
csum after mentioning them:

>  Block bitmap at 2 (+2), csum 0xc759340d, Inode bitmap at 18 (+18), csum 0x941e2bba

It would make more sense to report the group checksum on the first line:

Group 0: (Blocks 0-32767) csum 0xe0c6 [ITABLE_ZEROED]                                     

Unless it'll break peoples' scripts?

--D

>   24025 free blocks, 8181 free inodes, 2 directories, 8181 unused inodes
>   Free blocks: 8743-32767
>   Free inodes: 12-8192
> 
> 								- Ted
> 
> 
> 
> 
> 
> 
> > 
> > --D
> > > 
> > > +Reardon
> > > 
> > > 
> > > diff --git a/misc/dumpe2fs.c b/misc/dumpe2fs.c
> > > index a1c5ba2..d30cf87 100644
> > > --- a/misc/dumpe2fs.c
> > > +++ b/misc/dumpe2fs.c
> > > @@ -205,8 +205,6 @@ static void list_desc (ext2_filsys fs)
> > >                         printf(_("  Checksum 0x%04x"), csum);
> > >                         if (csum != exp_csum)
> > >                                 printf(_(" (EXPECTED 0x%04x)"), exp_csum);
> > > -                       printf(_(", unused inodes %u\n"),
> > > -                              ext2fs_bg_itable_unused(fs, i));
> > >                 }
> > >                 has_super = ((i==0) || super_blk);
> > >                 if (has_super) {
> > > 
> > > 
> > >  		 	   		  --
> > > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> > > the body of a message to majordomo@...r.kernel.org
> > > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html