linux-ext4 - Re: [PATCH 09/25] misc: zero s_jnl_blocks when removing internal journal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140912164342.GA10178@birch.djwong.org>
Date:	Fri, 12 Sep 2014 09:43:42 -0700
From:	"Darrick J. Wong" <darrick.wong@...cle.com>
To:	TR Reardon <thomas_reardon@...mail.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 09/25] misc: zero s_jnl_blocks when removing internal
 journal

[cc linux-ext4]

On Fri, Sep 12, 2014 at 10:09:55AM -0400, TR Reardon wrote:
> Note that this only works (zeroes out) when removing inode journal.  Removing
> an existing journal_dev leaves s_jnl_blocks untouched.  To be absolutely
> clean, perhaps it should be wiped in all removal cases?

s_jnl_blocks shouldn't be set if an external journal is in use.

(Unless it is somehow?)

--D

> 
> --- Original Message ---
> 
> From: "Theodore Ts'o" <tytso@....edu>
> Sent: September 11, 2014 12:44 PM
> To: "Darrick J. Wong" <darrick.wong@...cle.com>
> Cc: linux-ext4@...r.kernel.org, "TR Reardon" <thomas_reardon@...mail.com>
> Subject: Re: [PATCH 09/25] misc: zero s_jnl_blocks when removing internal journal
> 
> On Mon, Sep 08, 2014 at 04:12:35PM -0700, Darrick J. Wong wrote:
> > When we're removing the internal journal (broken journal, turning it
> > off, or adding an external journal), zero s_jnl_blocks so that they
> > can't be picked up by accident later.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>
> > Cc: TR Reardon <thomas_reardon@...mail.com>
> 
> Applied, thanks.
> 
>                                         - Ted
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html