linux-ext4 - Re: [PATCH 35/34] e2fsck: free bh when descriptor block checksum fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5415E85D.4070703@redhat.com>
Date:	Sun, 14 Sep 2014 14:11:25 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>, tytso@....edu
CC:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 35/34] e2fsck: free bh when descriptor block checksum
 fails

On 9/14/14 12:19 PM, Darrick J. Wong wrote:
> Free the buffer head if the journal descriptor block fails checksum
> verification.  This has been patched before (see "e2fsck: free bh on
> csum verify error in do_one_pass") but apparently the patch was never
> committed to jbd2 in the kernel, so when we resync'd the recovery code
> with 3.16, the bug came back.  Sigh.

Cool. 

Reviewed-by: Eric Sandeen <sandeen@...hat.com>

thanks for fixing up the kernel side... I hadn't thought about that,
obviously.  :(

-Eric

> Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>
> Cc: Eric Sandeen <sandeen@...hat.com>
> ---
>  e2fsck/recovery.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/e2fsck/recovery.c b/e2fsck/recovery.c
> index 3dc7c06..b5ce3b3 100644
> --- a/e2fsck/recovery.c
> +++ b/e2fsck/recovery.c
> @@ -525,6 +525,7 @@ static int do_one_pass(journal_t *journal,
>  			    !jbd2_descr_block_csum_verify(journal,
>  							  bh->b_data)) {
>  				err = -EIO;
> +				brelse(bh);
>  				goto failed;
>  			}
>  
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html