linux-ext4 - Re: [PATCH 2/3] ext4: support freezing ext2 (nojournal) file systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DF6FF9BB-702A-423B-B64E-2731A0347AE8@dilger.ca>
Date:	Thu, 18 Sep 2014 14:46:34 -0600
From:	Andreas Dilger <adilger@...ger.ca>
To:	Theodore Ts'o <tytso@....edu>
Cc:	Ext4 Developers List <linux-ext4@...r.kernel.org>,
	Dexuan Cui <decui@...rosoft.com>
Subject: Re: [PATCH 2/3] ext4: support freezing ext2 (nojournal) file systems

On Sep 18, 2014, at 2:26 PM, Theodore Ts'o <tytso@....edu> wrote:
> Through an oversight, when we added nojournal support to ext4, we
> didn't add support to allow file system freezing.  This is relatively
> easy to add, so let's do it.
> 
> Signed-off-by: Theodore Ts'o <tytso@....edu>
> Reported-by: Dexuan Cui <decui@...rosoft.com>
> ---
> fs/ext4/super.c | 27 ++++++++++++++++-----------
> 1 file changed, 16 insertions(+), 11 deletions(-)
> 
> @@ -4758,23 +4760,26 @@ static int ext4_freeze(struct super_block *sb)
> 
> 	journal = EXT4_SB(sb)->s_journal;
[snip]
> 	/* Journal blocked and flushed, clear needs_recovery flag. */
> 	EXT4_CLEAR_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_RECOVER);
> 	error = ext4_commit_super(sb, 1);
> out:
> -	/* we rely on upper layer to stop further updates */
> -	jbd2_journal_unlock_updates(EXT4_SB(sb)->s_journal);
> +	if (journal)
> +		/* we rely on upper layer to stop further updates */
> +		jbd2_journal_unlock_updates(EXT4_SB(sb)->s_journal);

This could use "journal" directly instead of "EXT4_SB(sb)->s_journal"

Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)