linux-ext4 - Re: [PATCH 2/2] ext4: Explicitly inform user about orphan list cleanup.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 18 Sep 2014 13:30:36 +0400
From:	Dmitry Monakhov <dmonakhov@...nvz.org>
To:	Lukáš Czerner <lczerner@...hat.com>,
	Theodore Ts'o <tytso@....edu>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 2/2] ext4: Explicitly inform user about orphan list cleanup.

On Thu, 18 Sep 2014 10:49:56 +0200 (CEST), Lukáš Czerner <lczerner@...hat.com> wrote:
> On Thu, 18 Sep 2014, Theodore Ts'o wrote:
> 
> > Date: Thu, 18 Sep 2014 00:29:07 -0400
> > From: Theodore Ts'o <tytso@....edu>
> > To: Dmitry Monakhov <dmonakhov@...nvz.org>
> > Cc: linux-ext4@...r.kernel.org
> > Subject: Re: [PATCH 2/2] ext4: Explicitly inform user about orphan list
> >     cleanup.
> > 
> > On Sun, Sep 14, 2014 at 04:38:57PM +0400, Dmitry Monakhov wrote:
> > > Production fs likely compiled/mounted w/o jbd debugging, so orphan list clearing
> > > will be silent.
> > > 
> > > Signed-off-by: Dmitry Monakhov <dmonakhov@...nvz.org>
> > 
> > Thanks, applied.
> 
> Hmm did not we just take this out recently with
> 
> 566370a2e56837be98bc62d012fc2d2d11851db4 ext4: suppress ext4 orphan
> messages on mount
The message I want to change appears only if file system contains
errors. So IMHO this is reasonable to make this message louder.
This is important because after orphan list will be directly cleared
later fsck will complain about incorrect dtime and corrupted orphan list.
Sane administrator should investigate why this happen. So leaving
precise message in /var/log/messages is good practice from our side.
> 
> and TBH I like it that way.
> 
> Thanks!
> -Lukas
> 
> > 
> > 					- Ted
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html