linux-ext4 - [PATCH v1 7/10] dirhash.c (ext2fs_dirhash): Remove redundant local variable p

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140923101938.3876.qmail@ns.horizon.com>
Date:	23 Sep 2014 06:19:38 -0400
From:	"George Spelvin" <linux@...izon.com>
To:	linux-ext4@...r.kernel.org
Cc:	linux@...izon.com, tytso@....edu
Subject: [PATCH v1 7/10] dirhash.c (ext2fs_dirhash): Remove redundant local variable p

This also makes the variable declarations line up better.

Signed-off-by: George Spelvin <linux@...izon.com>
---
 lib/ext2fs/dirhash.c | 17 +++++++----------
 1 file changed, 7 insertions(+), 10 deletions(-)

diff --git a/lib/ext2fs/dirhash.c b/lib/ext2fs/dirhash.c
index ef7820c..048486e 100644
--- a/lib/ext2fs/dirhash.c
+++ b/lib/ext2fs/dirhash.c
@@ -194,10 +194,9 @@ errcode_t ext2fs_dirhash(int version, const char *name, int len,
 {
 	__u32	hash;
 	__u32	minor_hash = 0;
-	const char	*p;
-	int		i;
-	__u32 		in[8], buf[4];
-	int		unsigned_flag = (version >= EXT2_HASH_UNSIGNED);
+	int	i;
+	__u32 	in[8], buf[4];
+	int	unsigned_flag = (version >= EXT2_HASH_UNSIGNED);
 
 	/* Initialize the default seed for the hash checksum functions */
 	buf[0] = 0x67452301;
@@ -222,24 +221,22 @@ errcode_t ext2fs_dirhash(int version, const char *name, int len,
 		break;
 	case EXT2_HASH_HALF_MD4:
 	case EXT2_HASH_HALF_MD4_UNSIGNED:
-		p = name;
 		while (len > 0) {
-			str2hashbuf(p, len, in, 8, unsigned_flag);
+			str2hashbuf(name, len, in, 8, unsigned_flag);
 			halfMD4Transform(buf, in);
 			len -= 32;
-			p += 32;
+			name += 32;
 		}
 		minor_hash = buf[2];
 		hash = buf[1];
 		break;
 	case EXT2_HASH_TEA:
 	case EXT2_HASH_TEA_UNSIGNED:
-		p = name;
 		while (len > 0) {
-			str2hashbuf(p, len, in, 4, unsigned_flag);
+			str2hashbuf(name, len, in, 4, unsigned_flag);
 			TEA_transform(buf, in);
 			len -= 16;
-			p += 16;
+			name += 16;
 		}
 		hash = buf[0];
 		minor_hash = buf[1];
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html