linux-ext4 - Re: [PATCH 3/3] ext4: optimize block allocation on grow indepth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140923100031.GD2359@quack.suse.cz>
Date:	Tue, 23 Sep 2014 12:00:31 +0200
From:	Jan Kara <jack@...e.cz>
To:	Dmitry Monakhov <dmonakhov@...nvz.org>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 3/3] ext4: optimize block allocation on grow indepth

On Tue 23-09-14 11:02:32, Dmitry Monakhov wrote:
> It is reasonable to prepent newly created index to older one.
...
> -	newblock = ext4_ext_new_meta_block(handle, inode, NULL,
> -		newext, &err, flags);
> +	/* Try to prepend new index to old one */
> +	if (ext_depth(inode))
> +		goal = ext4_idx_pblock(EXT_FIRST_INDEX(ext_inode_hdr(inode)));
> +	if (goal > le32_to_cpu(es->s_first_data_block)) {
> +		flags |= EXT4_MB_HINT_TRY_GOAL;
> +		goal--;
> +	} else
> +		goal =  ext4_inode_to_goal_block(inode);
> +	newblock = ext4_new_meta_blocks(handle, inode, goal, flags,
> +					NULL, &err);
>  	if (newblock == 0)
>  		return err;
  Hum, did you actually observe any improvement in file layout with this
patch?

								Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html