lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 29 Sep 2014 13:30:41 +0200 From: Jan Kara <jack@...e.cz> To: Li Xi <pkuelelixi@...il.com> Cc: linux-ext4@...r.kernel.org, tytso@....edu, adilger@...ger.ca, jack@...e.cz Subject: Re: [PATCH] ext4: fix return value of ext4_do_update_inode On Mon 29-09-14 09:58:34, Li Xi wrote: > When ext4_do_update_inode() gets error from ext4_inode_blocks_set(), > error number should be returned. Looks good. You can add: Reviewed-by: Jan Kara <jack@...e.cz> Honza > > Signed-off-by: Li Xi <lixi@....com> > --- > fs/ext4/inode.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c > index d5dd7d4..03ddfd7 100644 > --- a/fs/ext4/inode.c > +++ b/fs/ext4/inode.c > @@ -4204,7 +4204,8 @@ static int ext4_do_update_inode(handle_t *handle, > EXT4_INODE_SET_XTIME(i_atime, inode, raw_inode); > EXT4_EINODE_SET_XTIME(i_crtime, ei, raw_inode); > > - if (ext4_inode_blocks_set(handle, raw_inode, ei)) { > + err = ext4_inode_blocks_set(handle, raw_inode, ei); > + if (err) { > spin_unlock(&ei->i_raw_lock); > goto out_brelse; > } > -- > 1.7.1 > -- Jan Kara <jack@...e.cz> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists