linux-ext4 - Re: [PATCH] generic/017: skip tests with mkfs failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 7 Oct 2014 10:21:14 +1100
From:	Dave Chinner <david@...morbit.com>
To:	Paul Paulson <paul.paulson@...gate.com>
Cc:	fstests@...r.kernel.org, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] generic/017: skip tests with mkfs failures

On Mon, Oct 06, 2014 at 01:23:50PM -0500, Paul Paulson wrote:
> The mkfs command fails to create ext4 filesystems on partition sizes
> greater than 1998080 MiB when using 1024 byte blocks and the default
> calculation for the number of inodes reserved for the filesystem.

This is what the MKFS_OPTIONS field is for. We don't usually try to
work around specific perculiarities of specific filesystem configs
in individual tests.

> The following error message is produced when the maximum number of
> inodes is exceeded:
> 
>     "Cannot create filesystem with requested number of inodes while
>      setting up superblock"
> 
> The generic/017 test was modified to skip the 1K block size test
> for partitions with an inode count that exceeds the maximum.

Oh, I thought we got rid of the multiple block size loop in that
test.

Hmm - maybe I missed picking up that patch from Lucas after we
discussed it. I'll go back and pick it up, and then you won't have
this problem when testing default filesystem configs.

> diff --git a/tests/generic/017 b/tests/generic/017
> index 13b7254..eb38d4d 100755
> --- a/tests/generic/017
> +++ b/tests/generic/017
> @@ -49,8 +49,16 @@ _do_die_on_error=y
>  testfile=$SCRATCH_MNT/$seq.$$
>  BLOCKS=10240
>  
> -for (( BSIZE = 1024; BSIZE <= 4096; BSIZE *= 2 )); do
> +MAX_INODE_COUNT_1K=127877120
> +inode_count=`$TUNE2FS_PROG -l $SCRATCH_DEV | awk '/Inode count:/ { print $3 }'`
> +initial_bsize=$(($inode_count <= $MAX_INODE_COUNT_1K ? 1024 : 2048))

FWIW, that'll break every filesystem type other than ext4.

Cheers,

Dave.
-- 
Dave Chinner
david@...morbit.com
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html