linux-ext4 - Re: [PATCH] generic/017: skip tests with mkfs failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAG4SSaQg_2kZZsHUcO=q4m-P1CsD+ThyPcE58js+3sVWPymYAw@mail.gmail.com>
Date:	Tue, 7 Oct 2014 13:18:34 -0500
From:	Paul Paulson <paul.paulson@...gate.com>
To:	Dave Chinner <david@...morbit.com>
Cc:	fstests <fstests@...r.kernel.org>,
	linux-ext4 <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] generic/017: skip tests with mkfs failures

>> diff --git a/tests/generic/017 b/tests/generic/017
>> index 13b7254..eb38d4d 100755
>> --- a/tests/generic/017
>> +++ b/tests/generic/017
>> @@ -49,8 +49,16 @@ _do_die_on_error=y
>>  testfile=$SCRATCH_MNT/$seq.$$
>>  BLOCKS=10240
>>
>> -for (( BSIZE = 1024; BSIZE <= 4096; BSIZE *= 2 )); do
>> +MAX_INODE_COUNT_1K=127877120
>> +inode_count=`$TUNE2FS_PROG -l $SCRATCH_DEV | awk '/Inode count:/ { print $3 }'`
>> +initial_bsize=$(($inode_count <= $MAX_INODE_COUNT_1K ? 1024 : 2048))
>
> FWIW, that'll break every filesystem type other than ext4.
Yes, that was an oversight on my part. The initial_bsize calculation
should have taken filesystem type into account.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html