linux-ext4 - Re: BLKZEROOUT + pread should return zeroes, right?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 14 Oct 2014 09:44:00 -0400
From:	"Martin K. Petersen" <martin.petersen@...cle.com>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Dave Chinner <david@...morbit.com>,
	"Darrick J. Wong" <darrick.wong@...cle.com>,
	Jens Axboe <axboe@...nel.dk>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	linux-fsdevel@...r.kernel.org, "Theodore Ts'o" <tytso@....edu>,
	linux-ext4 <linux-ext4@...r.kernel.org>
Subject: Re: BLKZEROOUT + pread should return zeroes, right?

>>>>> "Christoph" == Christoph Hellwig <hch@...radead.org> writes:

>> Broken usage, IMO. If you are going to use the block layer ioctls to
>> manipulate data int eh block device, you should be using direct Io
>> for all your data IO to the block device. Otherwise, coherency
>> problems occur....

Christoph> I'd say BLKZEROOUT semantics are broken.  Having an ioctl
Christoph> exposed that maniulates on-disk data without cache coherence
Christoph> is a nightmare that people trip over easily.

I agree it's suboptimal but it's not different from how the other block
ioctls are working (discard, etc.).

The main issue is that the blkdev_issue_foobar() calls were designed for
in-kernel use and the calling filesystems were supposed to know what
they were doing with those pages. And for convenience we just wired up
the same calls as ioctls.

I'm undecided as to which hammer would be best.

-- 
Martin K. Petersen	Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html