linux-ext4 - Re: [PATCH] add aio/dio regression test race between write and fcntl V2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 14 Oct 2014 16:11:51 +1100
From:	Dave Chinner <david@...morbit.com>
To:	Dmitry Monakhov <dmonakhov@...nvz.org>
Cc:	fstests@...r.kernel.org, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] add aio/dio regression test race between write and fcntl
 V2

On Thu, Oct 09, 2014 at 06:57:22PM +0400, Dmitry Monakhov wrote:
> Original report: https://lkml.org/lkml/2014/10/8/545
> perform AIO-DIO and fcntl(F_SETFL) concurently
> Unaligned AIO likely result in synchronization which makes racewindow wider.
> 
> changes from v1->v2
>  - Properly reuse aio context

Couple of things below....

> 
> Signed-off-by: Dmitry Monakhov <dmonakhov@...nvz.org>
> ---
>  src/aio-dio-regress/aio-dio-fcntl-race.c |  148 ++++++++++++++++++++++++++++++
>  tests/generic/326                        |   51 ++++++++++
>  tests/generic/326.out                    |    2 +
>  tests/generic/group                      |    1 +
>  4 files changed, 202 insertions(+), 0 deletions(-)
>  create mode 100644 src/aio-dio-regress/aio-dio-fcntl-race.c
>  create mode 100755 tests/generic/326
>  create mode 100644 tests/generic/326.out
> 
> diff --git a/src/aio-dio-regress/aio-dio-fcntl-race.c b/src/aio-dio-regress/aio-dio-fcntl-race.c
> new file mode 100644
> index 0000000..835dbdf
> --- /dev/null
> +++ b/src/aio-dio-regress/aio-dio-fcntl-race.c
> @@ -0,0 +1,148 @@
> +/*
> + * Perform aio writes to file and toggle O_DIRECT flag concurrently
> + * this may trigger race between file->f_flags read and modification
> + * unuligned aio allow to makes race window wider.
> + * Regression test for https://lkml.org/lkml/2014/10/8/545
> + *
> + * Copyright (C) 2010 Red Hat, Inc. All Rights reserved.

YOu must have copied the code from somewhere. Can you add a note to
say where it came from in the patch description? And if you added
any significant modifications, you should add your own copyright to
it as well...

> diff --git a/tests/generic/326 b/tests/generic/326
> new file mode 100755
> index 0000000..8975a91
> --- /dev/null
> +++ b/tests/generic/326
> @@ -0,0 +1,51 @@
> +#! /bin/bash
> +# FS QA Test No. 326

Can you rename this to the first unused generic test?

> +# Run aio-dio-fcntl-race - test aio write race with O_DIRECT toggle
> +#
> +#-----------------------------------------------------------------------
> +# Copyright (c) 2009 Dmitry Monakhov.  All Rights Reserved.

2009 doesn't seem right for a test that was just written...

Cheers,

Dave.
-- 
Dave Chinner
david@...morbit.com
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html