linux-ext4 - Re: [PATCH 02/12] quota: Allow each filesystem to specify which quota types it supports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141022165150.GA12809@quack.suse.cz>
Date:	Wed, 22 Oct 2014 18:51:50 +0200
From:	Jan Kara <jack@...e.cz>
To:	Christoph Hellwig <hch@....de>
Cc:	Jan Kara <jack@...e.cz>, linux-fsdevel@...r.kernel.org,
	linux-ext4@...r.kernel.org, Dave Chinner <david@...morbit.com>,
	xfs@....sgi.com, cluster-devel@...hat.com,
	Steven Whitehouse <swhiteho@...hat.com>,
	Mark Fasheh <mfasheh@...e.com>,
	Joel Becker <jlbec@...lplan.org>, ocfs2-devel@....oracle.com,
	reiserfs-devel@...r.kernel.org, Jeff Mahoney <jeffm@...e.de>,
	Dave Kleikamp <shaggy@...nel.org>,
	jfs-discussion@...ts.sourceforge.net, tytso@....edu,
	viro@...iv.linux.org.uk
Subject: Re: [PATCH 02/12] quota: Allow each filesystem to specify which
 quota types it supports

On Wed 22-10-14 18:29:15, Christoph Hellwig wrote:
> On Tue, Oct 21, 2014 at 04:38:26PM +0200, Jan Kara wrote:
> > Currently all filesystems supporting VFS quota support user and group
> > quotas. With introduction of project quotas this is going to change so
> > make sure filesystem isn't called for quota type it doesn't support by
> > introduction of a bitmask determining which quota types each filesystem
> > supports.
> 
> Why don't you keep this bitmask in the dquot.c instead of pushing it
> to the caller?  So far usage of s_dquot is mostly confined to dquot.c
> (with a few leaks to the filesystems using it), so keeping it that
> way seems like a good idea.
  So there are two reasons:
1) Currently if you call quotactl() with invalid quota type you'll get
EINVAL. To maintain this with addition of project quotas you need to check
the types early before calling check_quotactl_permission() and other
checks.

2) I didn't want filesystem quotactl callbacks to deal with quota types
they don't support. Sure each fs could do a type check in the callback but
this looked easier.

Now I see your point about s_dquot and I can move allowed_types out of
s_dquot if that makes you happier. But otherwise what I did still seems as
the best solution to me.

								Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html