linux-ext4 - [PATCH 0/6] RFC: (partially) endian-annotate e2fsprogs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <54497296.8000708@redhat.com>
Date:	Thu, 23 Oct 2014 16:26:46 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	ext4 development <linux-ext4@...r.kernel.org>
Subject: [PATCH 0/6] RFC: (partially) endian-annotate e2fsprogs

This is really only partial, and in the end didn't spot any
actual problems.  And things are a bit odd and tricky, because
some structures (superblocks, inodes, etc) are swapped in-place
in the same structure (so they can't be easily annotated - 
if we wish to, we should define separate on-disk and in-memory
structures).

Further, i_block in the inode is sometimes swapped on read, and
sometimes not (!), depending on whether it's indirect blocks,
extents, or inline data.  So that's still messy too.

So this is really just kind of an RFC; I did it on a whim, and
things aren't yet totally sparse-check clean, but figured I'd send
it out and see what people think, whether it's worth merging,
or working on cleaning up the above issues to make it all tidier.

(sparse is pretty good at looking for casts in and out of blk64_t
too, though I haven't looked much at those.)

Thanks,
-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html