[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1415956537-11212-1-git-send-email-wangxg.fnst@cn.fujitsu.com>
Date: Fri, 14 Nov 2014 17:15:35 +0800
From: Xiaoguang Wang <wangxg.fnst@...fujitsu.com>
To: <linux-ext4@...r.kernel.org>
CC: <tytso@....edu>, <darrick.wong@...cle.com>,
Xiaoguang Wang <wangxg.fnst@...fujitsu.com>
Subject: [PATCH v3 1/3] e2fsprogs/tune2fs: fix memory leak in inode_scan_and_fix()
When we use ext2fs_open_inode_scan() to iterate inodes and finish
jobs, we also need a ext2fs_close_inode_scan(scan) operation, but in
inode_scan_and_fix(), we forgot to call it, fix this error.
Signed-off-by: Xiaoguang Wang <wangxg.fnst@...fujitsu.com>
Reviewed-by: Darrick J. Wong <darrick.wong@...cle.com>
---
misc/tune2fs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/misc/tune2fs.c b/misc/tune2fs.c
index 7fee870..065b483 100644
--- a/misc/tune2fs.c
+++ b/misc/tune2fs.c
@@ -2147,6 +2147,7 @@ static int inode_scan_and_fix(ext2_filsys fs, ext2fs_block_bitmap bmap)
err_out:
ext2fs_free_mem(&block_buf);
+ ext2fs_close_inode_scan(scan);
return retval;
}
--
1.8.2.1
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists