| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <546927D2.7050709@users.sourceforge.net> Date: Sun, 16 Nov 2014 23:40:18 +0100 From: SF Markus Elfring <elfring@...rs.sourceforge.net> To: Andrew Morton <akpm@...ux-foundation.org>, Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org CC: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org, Coccinelle <cocci@...teme.lip6.fr> Subject: [PATCH 1/1] fs-jbd: Deletion of an unnecessary check before the function call "iput" From: Markus Elfring <elfring@...rs.sourceforge.net> Date: Sun, 16 Nov 2014 23:23:19 +0100 The iput() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net> --- fs/jbd/journal.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/jbd/journal.c b/fs/jbd/journal.c index 06fe11e..32fe03e 100644 --- a/fs/jbd/journal.c +++ b/fs/jbd/journal.c @@ -1373,8 +1373,7 @@ int journal_destroy(journal_t *journal) } mutex_unlock(&journal->j_checkpoint_mutex); - if (journal->j_inode) - iput(journal->j_inode); + iput(journal->j_inode); if (journal->j_revoke) journal_destroy_revoke(journal); kfree(journal->j_wbuf); -- 2.1.3 -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists