linux-ext4 - Re: [PATCH 1/2] ext4: cleanup GFP flags inside resize path V2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141125180836.GD11648@thunk.org>
Date:	Tue, 25 Nov 2014 13:08:36 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	Dmitry Monakhov <dmonakhov@...nvz.org>
Cc:	linux-ext4@...r.kernel.org, cmm@...ibm.com
Subject: Re: [PATCH 1/2] ext4: cleanup GFP flags inside resize path V2

On Fri, Nov 14, 2014 at 01:40:39PM +0400, Dmitry Monakhov wrote:
> We must use GFP_NOFS instead GFP_KERNEL inside ext4_mb_add_groupinfo because resize-path
> call  it inside journal transaction. Call trace:
> ioctl
>  ->ext4_group_add
>    ->journal_start
>    ->ext4_setup_new_descs
>      ->ext4_mb_add_groupinfo -> GFP_KERNEL
>    ->ext4_flex_group_add
>      ->ext4_update_super
>        ->ext4_calculate_overhead  -> GFP_KERNEL
>    ->journal_stop
> 
> Changes from V1:
>  - Fix up gfp flags for ext4_calculate_overhead
> 
> ext4_update_super
> 
> Signed-off-by: Dmitry Monakhov <dmonakhov@...nvz.org>

Applied, thanks, with a slightly cleaned up commit description.

	 	      		 	    	   - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html