linux-ext4 - Re: [PATCH] jbd2: fix regression where we fail to initialize checksum seed when loading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141202030555.GA953@thunk.org>
Date:	Mon, 1 Dec 2014 22:05:55 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	linux-ext4@...r.kernel.org, Eric Whitney <enwlinux@...il.com>
Subject: Re: [PATCH] jbd2: fix regression where we fail to initialize
 checksum seed when loading

On Mon, Dec 01, 2014 at 04:22:23PM -0800, Darrick J. Wong wrote:
> When we're enabling journal features, we cannot use the predicate
> jbd2_journal_has_csum_v2or3() because we haven't yet set the sb
> feature flag fields!  Moreover, we just finished loading the shash
> driver, so the test is unnecessary; calculate the seed always.
> 
> Without this patch, we fail to initialize the checksum seed the first
> time we turn on journal_checksum, which means that all journal blocks
> written during that first mount are corrupt.  Transactions written
> after the second mount will be fine, since the feature flag will be
> set in the journal superblock.  xfstests generic/{034,321,322} are the
> regression tests.
> 
> (This is important for 3.18.)
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@...cle.coM>
> Reported-by: Eric Whitney <enwlinux@...il.com>

Applied, thanks.  I've confirmed this has fixed the xfstests
regressions, and I'll be sending this to Linus shortly.

	     	      	 	      - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html