linux-ext4 - [PATCH 50/47] e2fsck: remove 'invalid' wording from error when extent block fails checksum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20141203025251.GA10059@birch.djwong.org>
Date:	Tue, 2 Dec 2014 18:52:51 -0800
From:	"Darrick J. Wong" <darrick.wong@...cle.com>
To:	tytso@....edu
Cc:	linux-ext4@...r.kernel.org
Subject: [PATCH 50/47] e2fsck: remove 'invalid' wording from error when
 extent block fails checksum

Don't say the physical block number is invalid if an extent block
fails only the checksum.  It passes checks, so it's not invalid.

Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>
---
 e2fsck/problem.c                      |    2 +-
 tests/f_extent_int_bad_csum/expect.1  |    2 +-
 tests/f_extent_leaf_bad_csum/expect.1 |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/e2fsck/problem.c b/e2fsck/problem.c
index 75e0305..b1bcc0d 100644
--- a/e2fsck/problem.c
+++ b/e2fsck/problem.c
@@ -998,7 +998,7 @@ static struct e2fsck_problem problem_table[] = {
 	 */
 	{ PR_1_EXTENT_ONLY_CSUM_INVALID,
 	  N_("@i %i extent block passes checks, but checksum does not match "
-	     "extent\n\t(logical @b %c, @n physical @b %b, len %N)\n"),
+	     "extent\n\t(logical @b %c, physical @b %b, len %N)\n"),
 	  PROMPT_FIX, 0 },
 
 	/*
diff --git a/tests/f_extent_int_bad_csum/expect.1 b/tests/f_extent_int_bad_csum/expect.1
index 57a2a61..7b412b8 100644
--- a/tests/f_extent_int_bad_csum/expect.1
+++ b/tests/f_extent_int_bad_csum/expect.1
@@ -1,6 +1,6 @@
 Pass 1: Checking inodes, blocks, and sizes
 Inode 12 extent block passes checks, but checksum does not match extent
-	(logical block 698, invalid physical block 1788, len 1)
+	(logical block 698, physical block 1788, len 1)
 Fix? yes
 
 Pass 2: Checking directory structure
diff --git a/tests/f_extent_leaf_bad_csum/expect.1 b/tests/f_extent_leaf_bad_csum/expect.1
index 0dc78ad..86e501a 100644
--- a/tests/f_extent_leaf_bad_csum/expect.1
+++ b/tests/f_extent_leaf_bad_csum/expect.1
@@ -1,6 +1,6 @@
 Pass 1: Checking inodes, blocks, and sizes
 Inode 12 extent block passes checks, but checksum does not match extent
-	(logical block 7, invalid physical block 1090, len 1)
+	(logical block 7, physical block 1090, len 1)
 Fix? yes
 
 Pass 2: Checking directory structure
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html