linux-ext4 - Re: [PATCH 31/47] libext2fs/e2fsck: provide routines to read-ahead metadata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141215191941.GE5368@birch.djwong.org>
Date:	Mon, 15 Dec 2014 11:19:41 -0800
From:	"Darrick J. Wong" <darrick.wong@...cle.com>
To:	"Theodore Ts'o" <tytso@....edu>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 31/47] libext2fs/e2fsck: provide routines to read-ahead
 metadata

On Mon, Dec 15, 2014 at 12:36:28PM -0500, Theodore Ts'o wrote:
> On Fri, Nov 07, 2014 at 01:54:07PM -0800, Darrick J. Wong wrote:
> > 
> > v2: Add an API to create a dblist with a given number of list elements
> > pre-allocated.  This enables us to save ~2ms per call to
> > e2fsck_readahead() (assuming a 2MB RA buffer) by not having to
> > repeatedly call ext2_resize_mem as we add blocks to the list.
> 
> I don't see the API to create a dblist with a specified number of list
> elements?  It should be pretty trivial, given make_dblist() but I
> don't see it in this patch?

Ugh, part of the commit message came off.  There should be after that:

v3: Instead of creating dblists of arbitrary size, change the dblist
iterator to allow iterating a sub-range.  This eliminates a lot of
unnecessary list copying during e2fsck part2.

Sorry about that. :/

--D
> 
> 						- Ted
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html