linux-ext4 - Re: [PATCH 26/47] resize2fs: use old_fs to detect per-bg metadata blocks to free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141215020951.GB17575@thunk.org>
Date:	Sun, 14 Dec 2014 21:09:51 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 26/47] resize2fs: use old_fs to detect per-bg metadata
 blocks to free

On Fri, Nov 07, 2014 at 01:53:35PM -0800, Darrick J. Wong wrote:
> When shrinking a filesystem, resize2fs wants to free per-bg metadata
> blocks that are no longer needed.  This behavior is gated on whether
> there's a superblock in the group as told by new_fs.  The check really
> should be against old_fs, since we're effectively freeing blocks out
> of old_fs in the transition to new_fs, but prior to sparse_super2 this
> didn't matter since superblocks didn't move, so it didn't matter.
> 
> Under sparse_super2, however, there's a superblock in the last group,
> so now we need to change the test to use old_fs as it should.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>

Applied, thanks.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html