linux-ext4 - Re: [PATCH 30/47] resize2fs: don't play stupid games with the block count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141215031328.GF17575@thunk.org>
Date:	Sun, 14 Dec 2014 22:13:28 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 30/47] resize2fs: don't play stupid games with the block
 count

On Fri, Nov 07, 2014 at 01:54:01PM -0800, Darrick J. Wong wrote:
> While it may be true that playing games with old_fs' block count
> during a grow operation shuts up a bunch of warnings, resize2fs
> doesn't actually expand the group descriptor array to match the size
> we're artificially stuffing into old_fs, which means that if we
> actually need to allocate a block out of the larger fs (i.e. we're in
> desperation mode), ext2fs_block_alloc_stats2() scribbles on the heap,
> leading to crashes if you're lucky and FS corruption if not.
> 
> So, rip that piece out and turn off com_err warnings properly and add
> a test case to deal with growing a nearly full filesystem.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>

Applied, thanks.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html