linux-ext4 - Re: ext4_da_update_reserve_space warning fix not in stable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 7 Jan 2015 14:16:34 -0600
From:	Josh Hunt <johunt@...mai.com>
To:	Theodore Ts'o <tytso@....edu>
CC:	"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
	"adilger.kernel@...ger.ca" <adilger.kernel@...ger.ca>,
	"jack@...e.cz" <jack@...e.cz>
Subject: Re: ext4_da_update_reserve_space warning fix not in stable


On 01/07/2015 01:53 PM, Theodore Ts'o wrote:
> On Wed, Jan 07, 2015 at 12:12:59PM -0600, Josh Hunt wrote:
>> We are hitting the following warning in the field pretty frequently on the
>> latest 3.10 stable kernel:
>> [11708.763067] WARNING: at fs/ext4/inode.c:363
>> ext4_da_update_reserve_space+0x261/0x280 [ext4]()
>>
>> The issue was resolved via "ext4: fix warning in
>> ext4_da_update_reserve_space()" (7d7345322d60ed), but the fix was not
>> submitted as a stable update for 3.10. I was wondering if there's a reason
>> why this was not done, or if it was just overlooked?
>>
>> The patch appears to have a dependency on "quota: provide interface for
>> readding allocated space into reserved space" (1c8924eb106c1ac), so I think
>> both would need to be submitted if you feel it's possible.
>
> Have you tried backporting these two commits, and does it fix the
> problem for you?

Yeah I backported both. They both apply cleanly to 3.10 iirc. I will 
report back if they do not.

Yes, moving both of these to 3.10 fixes the problem for me.

>
> I think it was mostly an oversight, although it might have also been
> my thinking that it was only a warning, so it wasn't that critical to
> backport.  To be honest, I can't really recall exactly what happened
> with that patch at this point.
>
> If it does seen to work for you, I'm happy to suggest to the 3.10
> stable kernel maintainers to have it be backported.

That would be great, thanks!

Josh
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html