linux-ext4 - [PATCH ext4] ext4 crypto: ext4_fname

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 16 Jan 2015 10:27:32 +0800
From:	kbuild test robot <fengguang.wu@...el.com>
To:	Michael Halcrow <mhalcrow@...gle.com>
Cc:	kbuild-all@...org, Theodore Ts'o <tytso@....edu>,
	Uday Savagaonkar <savagaon@...gle.com>,
	Ildar Muslukhov <ildarm@...gle.com>,
	Andreas Dilger <adilger.kernel@...ger.ca>,
	linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH ext4] ext4 crypto: ext4_fname_decrypt() can be static

fs/ext4/crypto_fname.c:322:5: sparse: symbol 'ext4_fname_decrypt' was not declared. Should it be static?
fs/ext4/crypto_fname.c:380:5: sparse: symbol 'ext4_fname_encode_digest' was not declared. Should it be static?
fs/ext4/crypto_fname.c:479:6: sparse: symbol 'ext4_free_fname_crypto_ctx' was not declared. Should it be static?
fs/ext4/crypto_fname.c:532:30: sparse: symbol 'ext4_alloc_fname_crypto_ctx' was not declared. Should it be static?

Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
---
 crypto_fname.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/ext4/crypto_fname.c b/fs/ext4/crypto_fname.c
index e1a72d1..4b4b507 100644
--- a/fs/ext4/crypto_fname.c
+++ b/fs/ext4/crypto_fname.c
@@ -319,7 +319,7 @@ static int ext4_fname_encrypt(struct ext4_fname_crypto_ctx *ctx,
  *	Errors are returned as negative numbers.
  *	We trust the caller to allocate sufficient memory to oname string.
  */
-int ext4_fname_decrypt(struct ext4_fname_crypto_ctx *ctx,
+static int ext4_fname_decrypt(struct ext4_fname_crypto_ctx *ctx,
 		       struct ext4_cstr *oname,
 		       const struct ext4_cstr *iname)
 {
@@ -377,7 +377,7 @@ int ext4_fname_decrypt(struct ext4_fname_crypto_ctx *ctx,
  * Encodes the input digest using characters from the set [a-zA-Z0-9_+].
  * The encoded string is roughly 4/3 times the size of the input string.
  */
-int ext4_fname_encode_digest(char *dst, char *src, u32 len)
+static int ext4_fname_encode_digest(char *dst, char *src, u32 len)
 {
 	static const char *lookup_table =
 		"abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789_+";
@@ -476,7 +476,7 @@ out:
  *
  * Frees up a crypto context.
  */
-void ext4_free_fname_crypto_ctx(struct ext4_fname_crypto_ctx *ctx)
+static void ext4_free_fname_crypto_ctx(struct ext4_fname_crypto_ctx *ctx)
 {
 	if (ctx == NULL || IS_ERR(ctx))
 		return;
@@ -529,7 +529,7 @@ static struct ext4_fname_crypto_ctx *ext4_search_fname_crypto_ctx(
 /**
  * ext4_alloc_fname_crypto_ctx() -
  */
-struct ext4_fname_crypto_ctx *ext4_alloc_fname_crypto_ctx(
+static struct ext4_fname_crypto_ctx *ext4_alloc_fname_crypto_ctx(
 	const struct ext4_encryption_key *key)
 {
 	struct ext4_fname_crypto_ctx *ctx;
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html