linux-ext4 - Re: [PATCH] Fix of coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150120172709.GB24217@thunk.org>
Date:	Tue, 20 Jan 2015 12:27:09 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	Jan Mrazek <email@...zamrazek.cz>, linux-ext4@...r.kernel.org,
	trivial@...nel.org, Jiri Slaby <gep@...l.muni.cz>
Subject: Re: [PATCH] Fix of coding style

On Tue, Jan 20, 2015 at 01:37:31PM +0100, Jiri Slaby wrote:
> On 01/20/2015, 12:59 PM, Jan Mrazek wrote:
> > - init_timer changed to setup_timer
> > - multiline strings changed to single line (so it can be greped)
> > - other small conding style changes
> > 
> > Signed-off-by: Jan Mrazek <email@...zamrazek.cz>
> 
> Note that one hunk does not apply cleanly here:
>  Hunk #35 succeeded at 3581 with fuzz 1 (offset 16 lines).
> 
> What tree did you use as a base? Care to rebase?
> 
> Reviewed-by: Jiri Slaby <jslaby@...e.cz>
> 
> (There is a nit: leaving up to the maintainers if they insist on
> separating the setup_timer change or not :).)

Yes, please separate it out; in general I'm not terribly excited about
these sorts of massive cleanup patches, because it breaks patches that
other people send me.  (I'll also note that many of the multi-line
separations happened people running checkpatch sent me cleanup
patches; so the fact that I'm now getting a cleanup patch to reverse
this also predisposes me to not be very receptive to these sorts of
cleanups.  I will generally ask developers to send me checkpatch clean
patches, but I'm less enthusiastic about cleanup patches for their own
sake.)

That being said, the setup_timer change is small, and less disruptive,
so separating that out is good because I will likely accept the
setup_timer change, but probably not the multi-line string change,
since regardless of what you base it against, there is a very good
chance it won't apply against the ext4 development tree --- and if it
does, it will likely break other patches that people send me.

Cheers,

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html