linux-ext4 - Re: [PATCH-v7 1/3] vfs: add support for a lazytime mount option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150125030352.GB9287@thunk.org>
Date:	Sat, 24 Jan 2015 22:03:52 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	Dmitry Monakhov <dmonlist@...il.com>
Cc:	Linux Filesystem Development List <linux-fsdevel@...r.kernel.org>,
	Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH-v7 1/3] vfs: add support for a lazytime mount option

On Mon, Jan 19, 2015 at 06:21:31PM +0400, Dmitry Monakhov wrote:
> > +	if (flags & I_DIRTY_INODE)
> > +		flags &= ~I_DIRTY_TIME;
> > +	dirtytime = flags & I_DIRTY_TIME;
> TYPO? 'dirtytime' is always false because you have already cleared that bit.
> Probably you want to do that: 
>         dirtytime = flags & I_DIRTY_TIME;
> 	if (flags & I_DIRTY_INODE)
> 		flags &= ~I_DIRTY_TIME;

Nice catch; I screwed that up in the -v7 version of the patch.  I've
fixed it in the -v8 version that I just sent out.

      	    	    	    	   	- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html