linux-ext4 - Re: [PATCH 12/54] e2fsck: clear i_block[] when there are too many bad mappings on a special inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150127163238.GL2453@thunk.org>
Date:	Tue, 27 Jan 2015 11:32:38 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 12/54] e2fsck: clear i_block[] when there are too many
 bad mappings on a special inode

On Mon, Jan 26, 2015 at 11:36:50PM -0800, Darrick J. Wong wrote:
> If we decide to clear a special inode because of bad mappings, we need
> to zero the i_block array.  The clearing routine depends on setting
> i_links_count to zero to keep us from re-checking the block maps,
> but that field isn't checked for special inodes.  Therefore, if we
> haven't erased the mappings, check_blocks will restart fsck and fsck
> will try to check the blocks again, leading to an infinite loop.
> 
> (This seems easy to trigger if the bootloader inode extent map is
> corrupted.)
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>

Applied, thanks.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html