linux-ext4 - Re: [PATCH 16/54] e2fsck: decrement bad count _after

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150128135841.GP2453@thunk.org>
Date:	Wed, 28 Jan 2015 08:58:41 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 16/54] e2fsck: decrement bad count _after_ remapping a
 duplicate block

On Mon, Jan 26, 2015 at 11:37:18PM -0800, Darrick J. Wong wrote:
> Decrement the bad count *after* we've shown that (a) we can allocate a
> replacement block and (b) remap the file block.  Unfortunately,
> the only way to tell if the remapping succeeded is to wait until the
> next clone_file_block() call or block_iterate3() returns.
> 
> Otherwise, there's a corruption error: we decrease the badcount once in
> preparation to remap, then the remap fails (either we can't find a
> replacement block or we have to split the extent tree and can't find a
> new extent block), so we delete the file, which decreases the badcount
> on the block a second time.  Later on e2fsck will think that it's
> straightened out all the duplicate blocks, which isn't true.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>

Applied, thanks.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html