linux-ext4 - Re: [PATCH 15/54] e2fsck: handle multiple *ind block collisions with critical metadata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150128135254.GO2453@thunk.org>
Date:	Wed, 28 Jan 2015 08:52:54 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 15/54] e2fsck: handle multiple *ind block collisions with
 critical metadata

On Mon, Jan 26, 2015 at 11:37:10PM -0800, Darrick J. Wong wrote:
> An earlier patch tried to detect indirect blocks that conflicted with
> critical FS metadata for the purpose of preventing corrections being
> made to those indirect blocks.  Unfortunately, that patch cannot
> handle more than one conflicting *ind block per file; therefore, use
> the ref_block parameter to test the metadata block map to decide if
> we need to avoid fixing the *ind block when we're iterating the
> block's entries.  (We have to iterate the block to capture any blocks
> that the block points to, as they could be in use.)
> 
> As a side note, in 1B we'll reallocate all those conflicting *ind
> blocks and restart fsck, so the contents will be checked eventually.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>

Applied, thanks.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html