linux-ext4 - Re: [PATCH] ext4: fix transposition typo in format string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150402204748.GC450@thunk.org>
Date:	Thu, 2 Apr 2015 16:47:48 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:	Andreas Dilger <adilger.kernel@...ger.ca>,
	linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ext4: fix transposition typo in format string

On Fri, Feb 20, 2015 at 03:11:35PM +0100, Rasmus Villemoes wrote:
> According to C99, %*.s means the same as %*.0s, in other words, print
> as many spaces as the field width argument says and effectively ignore
> the string argument. That is certainly not what was meant here. The
> kernel's printf implementation, however, treats it as if the . was not
> there, i.e. as %*s. I don't know if de->name is nul-terminated or not,
> but in any case I'm guessing the intention was to use de->name_len as
> precision instead of field width.

Applied, sorry for the delay.

(Note: the code is explicitly #ifdef'ed out so the only way the bug
would show up is if a developer explicitly modified the source to
#define INLINE_DIR_DEBUG, so it's not -stable material.)

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html